hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1311: [HUDI-602] Add some guidance about how to judge the scope of MINOR to the contribution guidance
Date Thu, 06 Feb 2020 18:14:34 GMT
vinothchandar commented on a change in pull request #1311: [HUDI-602] Add some guidance about
how to judge the scope of MINOR to the contribution guidance
URL: https://github.com/apache/incubator-hudi/pull/1311#discussion_r375998821
 
 

 ##########
 File path: docs/_pages/contributing.cn.md
 ##########
 @@ -88,7 +88,11 @@ and more importantly also try to improve the process along the way as
well.
 
  - Once you finalize on a project/task, please open a new JIRA or assign an existing one
to yourself. 
       - Almost all PRs should be linked to a JIRA. It's always good to have a JIRA upfront
to avoid duplicating efforts.
-      - If the changes are minor, then `[MINOR]` prefix can be added to Pull Request title
without a JIRA. 
+      - If the changes are minor, then `[MINOR]` prefix can be added to Pull Request title
without a JIRA. There are some tips to help to judge **MINOR** Pull Request :
+        - trivial fixes (for example, a typo, a broken link or an obvious error)
+        - the change is not functionality relevant
+        - changed lines less than 50
 
 Review comment:
   We could make the limit larger to say 100.. may be? but I do feel there should be a limit.
we are not saying we won't take larger code changes. Just saying if someone is going to change
300 files and cause everyone to rebase/resolve conflicts, lets have them file a JIRA and get
some consensus.. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message