hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] n3nash commented on a change in pull request #1307: [HUDI-570] - Improve test coverage for FSUtils.java
Date Wed, 05 Feb 2020 03:08:32 GMT
n3nash commented on a change in pull request #1307: [HUDI-570] - Improve test coverage for
FSUtils.java
URL: https://github.com/apache/incubator-hudi/pull/1307#discussion_r375038980
 
 

 ##########
 File path: hudi-common/src/test/java/org/apache/hudi/common/util/TestFSUtils.java
 ##########
 @@ -43,11 +49,33 @@
 import java.util.stream.Stream;
 
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
 
 /**
  * Tests file system utils.
  */
 public class TestFSUtils extends HoodieCommonTestHarness {
+  private long minRollbackToKeep = 10;
+  private long minCleanToKeep = 10;
+  protected transient FileSystem fs;
+  protected String basePath = null;
+
+  @Before
 
 Review comment:
   You don't need this init, the HoodieTestHarness actually creates a DFS based file system
which works for log records and should not run into the exception for which you might be creating
the local file system 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message