hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] hddong commented on a change in pull request #1242: [HUDI-544] Adjust the read and write path of archive
Date Tue, 04 Feb 2020 02:52:58 GMT
hddong commented on a change in pull request #1242: [HUDI-544] Adjust the read and write path
of archive
URL: https://github.com/apache/incubator-hudi/pull/1242#discussion_r374451280
 
 

 ##########
 File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/ArchivedCommitsCommand.java
 ##########
 @@ -63,10 +63,7 @@ public String showArchivedCommits(
       throws IOException {
     System.out.println("===============> Showing only " + limit + " archived commits <===============");
     String basePath = HoodieCLI.getTableMetaClient().getBasePath();
-    Path archivePath = new Path(basePath + "/.hoodie/.commits_.archive*");
-    if (folder != null && !folder.isEmpty()) {
-      archivePath = new Path(basePath + "/.hoodie/" + folder);
-    }
+    Path archivePath = new Path(HoodieCLI.getTableMetaClient().getArchivePath() + "/.commits_.archive*");
 
 Review comment:
   > I'm assuming `HoodieCLI.getTableMetaClient().getArchivePath()` returns the path with
`.hoodie` ?
   
   Yes, it read from metadata and include `.hoodie`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message