hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] hddong commented on a change in pull request #1242: [HUDI-544] Adjust the read and write path of archive
Date Sat, 01 Feb 2020 02:21:54 GMT
hddong commented on a change in pull request #1242: [HUDI-544] Adjust the read and write path
of archive
URL: https://github.com/apache/incubator-hudi/pull/1242#discussion_r373751253
 
 

 ##########
 File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/ArchivedCommitsCommand.java
 ##########
 @@ -54,7 +55,6 @@
 
   @CliCommand(value = "show archived commit stats", help = "Read commits from archived files
and show details")
   public String showArchivedCommits(
-      @CliOption(key = {"archiveFolderPattern"}, help = "Archive Folder", unspecifiedDefaultValue
= "") String folder,
 
 Review comment:
   > If remove this option, user can not use specified path.
   
   IMO, it is not need here, `archiveFolder` is stored in ` .hoodie`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message