From commits-return-10638-archive-asf-public=cust-asf.ponee.io@hudi.apache.org  Mon Jan 27 18:52:58 2020
Return-Path: <commits-return-10638-archive-asf-public=cust-asf.ponee.io@hudi.apache.org>
X-Original-To: archive-asf-public@cust-asf.ponee.io
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [207.244.88.153])
	by mx-eu-01.ponee.io (Postfix) with SMTP id A6E4B18060E
	for <archive-asf-public@cust-asf.ponee.io>; Mon, 27 Jan 2020 19:52:57 +0100 (CET)
Received: (qmail 22696 invoked by uid 500); 27 Jan 2020 18:52:57 -0000
Mailing-List: contact commits-help@hudi.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@hudi.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@hudi.apache.org>
List-Post: <mailto:commits@hudi.apache.org>
List-Id: <commits.hudi.apache.org>
Reply-To: dev@hudi.apache.org
Delivered-To: mailing list commits@hudi.apache.org
Received: (qmail 22678 invoked by uid 99); 27 Jan 2020 18:52:57 -0000
Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Jan 2020 18:52:57 +0000
From: GitBox <git@apache.org>
To: commits@hudi.apache.org
Subject: [GitHub] [incubator-hudi] n3nash commented on a change in pull request
 #1278: [HUDI-573] Refactoring getter to avoid double extrametadata in json
 representation of HoodieCommitMetadata
Message-ID: <158015117702.14907.3476738190965065486.gitbox@gitbox.apache.org>
References: <hudi.1278.MDExOlB1bGxSZXF1ZXN0MzY2NzE3OTE4.gitbox@gitbox.apache.org>
In-Reply-To: <hudi.1278.MDExOlB1bGxSZXF1ZXN0MzY2NzE3OTE4.gitbox@gitbox.apache.org>
Date: Mon, 27 Jan 2020 18:52:57 -0000
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

n3nash commented on a change in pull request #1278: [HUDI-573] Refactoring getter to avoid double extrametadata in json representation of HoodieCommitMetadata
URL: https://github.com/apache/incubator-hudi/pull/1278#discussion_r371418845
 
 

 ##########
 File path: hudi-common/src/main/java/org/apache/hudi/common/model/HoodieCommitMetadata.java
 ##########
 @@ -47,15 +47,15 @@
   protected Map<String, List<HoodieWriteStat>> partitionToWriteStats;
   protected Boolean compacted;
 
-  private Map<String, String> extraMetadataMap;
+  private Map<String, String> extraMetadata;
 
 Review comment:
   So the change I have done doesn't change AVRO generated pojo, so that should work just fine.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services