From commits-return-9840-archive-asf-public=cust-asf.ponee.io@hudi.apache.org Thu Jan 16 01:24:28 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 54CAD18065E for ; Thu, 16 Jan 2020 02:24:28 +0100 (CET) Received: (qmail 1566 invoked by uid 500); 16 Jan 2020 01:24:27 -0000 Mailing-List: contact commits-help@hudi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hudi.apache.org Delivered-To: mailing list commits@hudi.apache.org Received: (qmail 1557 invoked by uid 99); 16 Jan 2020 01:24:27 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Jan 2020 01:24:27 +0000 From: GitBox To: commits@hudi.apache.org Subject: [GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1212: [HUDI-509] Renaming code in sync with cWiki restructuring Message-ID: <157913786767.11053.4749744509310145827.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Thu, 16 Jan 2020 01:24:27 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit vinothchandar commented on a change in pull request #1212: [HUDI-509] Renaming code in sync with cWiki restructuring URL: https://github.com/apache/incubator-hudi/pull/1212#discussion_r367190262 ########## File path: hudi-hive/src/main/java/org/apache/hudi/hive/HiveSyncTool.java ########## @@ -53,30 +53,44 @@ public class HiveSyncTool { private static final Logger LOG = LogManager.getLogger(HiveSyncTool.class); - private final HoodieHiveClient hoodieHiveClient; - public static final String SUFFIX_REALTIME_TABLE = "_rt"; + public static final String SUFFIX_SNAPSHOT_TABLE = "_rt"; + public static final String SUFFIX_READ_OPTIMIZED_TABLE = "_ro"; Review comment: @n3nash the reason was.. without this, it gets kind of confusing that the snapshot query on COW hits the table with no prefix and on MOR, its not the snapshot table.. So wanted to clearly call out `_ro` ... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services