From commits-return-9494-archive-asf-public=cust-asf.ponee.io@hudi.apache.org Sat Jan 11 22:41:15 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 777A218067F for ; Sat, 11 Jan 2020 23:41:14 +0100 (CET) Received: (qmail 9745 invoked by uid 500); 11 Jan 2020 22:41:13 -0000 Mailing-List: contact commits-help@hudi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hudi.apache.org Delivered-To: mailing list commits@hudi.apache.org Received: (qmail 9658 invoked by uid 99); 11 Jan 2020 22:41:13 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 Jan 2020 22:41:13 +0000 From: GitBox To: commits@hudi.apache.org Subject: [GitHub] [incubator-hudi] nsivabalan commented on a change in pull request #1187: [HUDI-499] Allow update partition path with GLOBAL_BLOOM Message-ID: <157878247347.3888.15525682194240741.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Sat, 11 Jan 2020 22:41:13 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit nsivabalan commented on a change in pull request #1187: [HUDI-499] Allow update partition path with GLOBAL_BLOOM URL: https://github.com/apache/incubator-hudi/pull/1187#discussion_r365545094 ########## File path: hudi-client/src/main/java/org/apache/hudi/config/HoodieIndexConfig.java ########## @@ -77,6 +77,9 @@ public static final String BLOOM_INDEX_INPUT_STORAGE_LEVEL = "hoodie.bloom.index.input.storage.level"; public static final String DEFAULT_BLOOM_INDEX_INPUT_STORAGE_LEVEL = "MEMORY_AND_DISK_SER"; + public static final String BLOOM_INDEX_SHOULD_UPDATE_PARTITION_PATH = "hoodie.bloom.index.should.update.partition.path"; Review comment: Also, can we add some java docs since the property is not very intuitive. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services