From commits-return-9343-archive-asf-public=cust-asf.ponee.io@hudi.apache.org Thu Jan 9 14:55:53 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 69C1018063F for ; Thu, 9 Jan 2020 15:55:53 +0100 (CET) Received: (qmail 82609 invoked by uid 500); 9 Jan 2020 14:55:52 -0000 Mailing-List: contact commits-help@hudi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hudi.apache.org Delivered-To: mailing list commits@hudi.apache.org Received: (qmail 82600 invoked by uid 99); 9 Jan 2020 14:55:52 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Jan 2020 14:55:52 +0000 From: GitBox To: commits@hudi.apache.org Subject: [GitHub] [incubator-hudi] sev7e0 commented on a change in pull request #1161: [HUDI-457]Redo hudi-common log statements using SLF4J Message-ID: <157858175272.13181.11967952385142483612.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Thu, 09 Jan 2020 14:55:52 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit sev7e0 commented on a change in pull request #1161: [HUDI-457]Redo hudi-common log statements using SLF4J URL: https://github.com/apache/incubator-hudi/pull/1161#discussion_r364782798 ########## File path: hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java ########## @@ -324,7 +324,7 @@ public static HoodieTableMetaClient initTableType(Configuration hadoopConf, Stri */ public static HoodieTableMetaClient initDatasetAndGetMetaClient(Configuration hadoopConf, String basePath, Properties props) throws IOException { - LOG.info("Initializing " + basePath + " as hoodie dataset " + basePath); + LOG.info("Initializing {} as hoodie dataset {}", basePath, basePath); Review comment: Thanks, change it now. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services