From commits-return-9159-archive-asf-public=cust-asf.ponee.io@hudi.apache.org Wed Jan 8 01:33:09 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 26454180643 for ; Wed, 8 Jan 2020 02:33:09 +0100 (CET) Received: (qmail 40768 invoked by uid 500); 8 Jan 2020 01:33:08 -0000 Mailing-List: contact commits-help@hudi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hudi.apache.org Delivered-To: mailing list commits@hudi.apache.org Received: (qmail 40758 invoked by uid 99); 8 Jan 2020 01:33:08 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Jan 2020 01:33:08 +0000 From: GitBox To: commits@hudi.apache.org Subject: [GitHub] [incubator-hudi] dengziming commented on issue #1185: [HUDI-500] Use enum method to replace switch case Message-ID: <157844718841.8470.17197257164390754280.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Wed, 08 Jan 2020 01:33:08 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit dengziming commented on issue #1185: [HUDI-500] Use enum method to replace switch case URL: https://github.com/apache/incubator-hudi/pull/1185#issuecomment-571851785 thank you @bvaradar , I thind you are right, it not a good design to bring to many abstraction layers. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services