From commits-return-9127-archive-asf-public=cust-asf.ponee.io@hudi.apache.org Tue Jan 7 20:38:31 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id E4A11180643 for ; Tue, 7 Jan 2020 21:38:30 +0100 (CET) Received: (qmail 85199 invoked by uid 500); 7 Jan 2020 20:38:30 -0000 Mailing-List: contact commits-help@hudi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hudi.apache.org Delivered-To: mailing list commits@hudi.apache.org Received: (qmail 85189 invoked by uid 99); 7 Jan 2020 20:38:30 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Jan 2020 20:38:30 +0000 From: GitBox To: commits@hudi.apache.org Subject: [GitHub] [incubator-hudi] bvaradar commented on issue #1185: [HUDI-500] Use enum method to replace switch case Message-ID: <157842951010.27673.10854844572493068765.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Tue, 07 Jan 2020 20:38:30 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit bvaradar commented on issue #1185: [HUDI-500] Use enum method to replace switch case URL: https://github.com/apache/incubator-hudi/pull/1185#issuecomment-571760972 Thanks @dengziming. I agree with @vinothchandar to keep abstraction layers smaller and well defined to preserve orthogonality. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services