From commits-return-8686-archive-asf-public=cust-asf.ponee.io@hudi.apache.org Thu Jan 2 03:20:52 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id ADA7D18069C for ; Thu, 2 Jan 2020 04:20:51 +0100 (CET) Received: (qmail 12559 invoked by uid 500); 2 Jan 2020 03:20:51 -0000 Mailing-List: contact commits-help@hudi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hudi.apache.org Delivered-To: mailing list commits@hudi.apache.org Received: (qmail 12321 invoked by uid 99); 2 Jan 2020 03:20:50 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Jan 2020 03:20:50 +0000 From: GitBox To: commits@hudi.apache.org Subject: [GitHub] [incubator-hudi] yanghua commented on a change in pull request #1161: [HUDI-457]Redo hudi-common log statements using SLF4J Message-ID: <157793525053.9504.17398501812547176506.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Thu, 02 Jan 2020 03:20:50 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit yanghua commented on a change in pull request #1161: [HUDI-457]Redo hudi-common log statements using SLF4J URL: https://github.com/apache/incubator-hudi/pull/1161#discussion_r362363178 ########## File path: hudi-common/src/main/java/org/apache/hudi/common/table/view/SpillableMapBasedFileSystemView.java ########## @@ -80,8 +80,8 @@ public SpillableMapBasedFileSystemView(HoodieTableMetaClient metaClient, HoodieT protected Map> createFileIdToPendingCompactionMap( Map> fgIdToPendingCompaction) { try { - LOG.info("Creating Pending Compaction map using external spillable Map. Max Mem=" + maxMemoryForPendingCompaction - + ", BaseDir=" + baseStoreDir); + LOG.info("Creating Pending Compaction map using external spillable Map. Max Mem={}, BaseDir={}", + maxMemoryForPendingCompaction, baseStoreDir); Review comment: ditto about indent ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services