hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] zhedoubushishi opened a new pull request #1226: [HUDI-238] Make Hudi support Scala 2.12
Date Tue, 14 Jan 2020 07:13:39 GMT
zhedoubushishi opened a new pull request #1226: [HUDI-238] Make Hudi support Scala 2.12
URL: https://github.com/apache/incubator-hudi/pull/1226
 
 
   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contributing.html before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   *(For example: This pull request adds quick-start document.)*
   
   ## Brief change log
   
   Most ideas of this PR is pretty similar to https://github.com/apache/incubator-hudi/pull/1109.

   
   This PR is also compatible with Scala 2.12. You can build it with: 
   ```mvn clean install -Dscala.version=2.12.10 -scala.binary.version=2.12```
   
   Here are some major differences between https://github.com/apache/incubator-hudi/pull/1109:
   - updated kafka-source.properties & kafka-source.properties .
   - This parameter: ```ConsumerConfig.GROUP_ID_CONFIG``` is defined in ```TestKafkaSource.java```
rather than in ```KafkaOffsetGen.java```. Because this config should be decided by the client
side but not the Hudi side.
   -  For ```AvroKafkaSource.java ```, ```KafkaAvroDeserializer.class``` need to be set.
   ```
       props.put("key.deserializer", StringDeserializer.class);
       props.put("value.deserializer", KafkaAvroDeserializer.class);
   ```
   ## Verify this pull request
   
   This pull request is already covered by existing tests.
   
   
   ## Committer checklist
   
    - [x] Has a corresponding JIRA in PR title & commit
    
    - [x] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella
JIRA.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message