hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] prashantwason opened a new pull request #1221: [HUDI-527] scalastyle-maven-plugin moved to pluginManagement as it ionly used in hoodie-spark and hoodie-cli modules
Date Mon, 13 Jan 2020 20:13:58 GMT
prashantwason opened a new pull request #1221: [HUDI-527] scalastyle-maven-plugin moved to
pluginManagement as it ionly used in hoodie-spark and hoodie-cli modules
URL: https://github.com/apache/incubator-hudi/pull/1221
 
 
   ## What is the purpose of the pull request
   
   This fixes scalastyle-maven-plugin warnings as well as unnecessary plugin invocation for
most of the modules which do not have scala code.
   
   ## Brief change log
   - Scala code is used in only hudi-cli and hudi-spark modules
   - scalastyle-maven-plugin has been moved from pom.xml <plugin> to <pluginManagement>
   - <plugin> entries have been added in hudi-cli/pom.xml and hudi-spark/pom.xml
   
   This ensures that the scalastyle-maven-plugin will only be executed for the modules which
have scala code.
   
   ## Verify this pull request
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   mvn clean package 
   
   ## Committer checklist
   
    - [ *] Has a corresponding JIRA in PR title & commit
    
    - [ *] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella
JIRA.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message