hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] n3nash commented on a change in pull request #1290: [HUDI-584] Relocate spark-avro dependency by maven-shade-plugin
Date Wed, 29 Jan 2020 19:13:38 GMT
n3nash commented on a change in pull request #1290: [HUDI-584] Relocate spark-avro dependency
by maven-shade-plugin
URL: https://github.com/apache/incubator-hudi/pull/1290#discussion_r372577925
 
 

 ##########
 File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/HoodieLogFileCommand.java
 ##########
 @@ -104,7 +104,7 @@ public String showLogFileCommits(
           try {
             instantTime = n.getLogBlockHeader().get(HeaderMetadataType.INSTANT_TIME);
             if (instantTime == null) {
-              throw new Exception("Invalid instant time " + instantTime);
 
 Review comment:
   just leave it as instantTime ? (also this change is different from what the PR says so
lets not have it in this PR)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message