hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] n3nash commented on a change in pull request #1242: [HUDI-544] Adjust the read and write path of archive
Date Mon, 27 Jan 2020 19:07:40 GMT
n3nash commented on a change in pull request #1242: [HUDI-544] Adjust the read and write path
of archive
URL: https://github.com/apache/incubator-hudi/pull/1242#discussion_r371426141
 
 

 ##########
 File path: hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableConfig.java
 ##########
 @@ -68,7 +68,7 @@
   public static final HoodieFileFormat DEFAULT_LOG_FILE_FORMAT = HoodieFileFormat.HOODIE_LOG;
   public static final String DEFAULT_PAYLOAD_CLASS = OverwriteWithLatestAvroPayload.class.getName();
   public static final Integer DEFAULT_TIMELINE_LAYOUT_VERSION = TimelineLayoutVersion.VERSION_0;
-  public static final String DEFAULT_ARCHIVELOG_FOLDER = "";
+  public static final String DEFAULT_ARCHIVELOG_FOLDER = "archived";
 
 Review comment:
   @vinothchandar that's correct, we don't override this and all commits archived data at
Uber is written to .hoodie/`.`
   
   @hddong this change doesn't seem necessary but has serious concerns for older data written
(even by other users who might not be overriding the archived folder name), could you please
revert it ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message