hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] xushiyan commented on a change in pull request #1187: [HUDI-499] Allow update partition path with GLOBAL_BLOOM
Date Sun, 26 Jan 2020 19:04:05 GMT
xushiyan commented on a change in pull request #1187: [HUDI-499] Allow update partition path
with GLOBAL_BLOOM
URL: https://github.com/apache/incubator-hudi/pull/1187#discussion_r371022085
 
 

 ##########
 File path: hudi-client/src/main/java/org/apache/hudi/config/HoodieIndexConfig.java
 ##########
 @@ -77,6 +77,17 @@
   public static final String BLOOM_INDEX_INPUT_STORAGE_LEVEL = "hoodie.bloom.index.input.storage.level";
   public static final String DEFAULT_BLOOM_INDEX_INPUT_STORAGE_LEVEL = "MEMORY_AND_DISK_SER";
 
+  /**
+   * Only applies if index type is GLOBAL_BLOOM.
+   * <p>
+   * When set to true, an update including the partition path of a record that already exists
will result in inserting
+   * the incoming record into the new partition and deleting the original record in the old
partition.
+   * <p>
+   * When set to false, the original record will only be updated in the old partition.
+   */
+  public static final String GLOBAL_BLOOM_INDEX_SHOULD_UPDATE_PARTITION_PATH = "hoodie.global.bloom.index.should.update.partition.path";
 
 Review comment:
   > Since this applies to the bloom index, can we slightly rename to `hoodie.bloom.index.update.partition.path`
and also shorten it a bit
   
   I like the brevity. As the docs specify as "only apply to GLOBAL_BLOOM", it is unlikely
to confuse users.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message