hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] n3nash commented on a change in pull request #1274: [HUDI-571] Add 'commits show archived' command to CLI
Date Fri, 24 Jan 2020 22:03:43 GMT
n3nash commented on a change in pull request #1274: [HUDI-571] Add 'commits show archived'
command to CLI
URL: https://github.com/apache/incubator-hudi/pull/1274#discussion_r370862726
 
 

 ##########
 File path: hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java
 ##########
 @@ -289,11 +288,8 @@ public ConsistencyGuardConfig getConsistencyGuardConfig() {
    *
    * @return Active commit timeline
    */
-  public synchronized HoodieArchivedTimeline getArchivedTimeline() {
-    if (archivedTimeline == null) {
-      archivedTimeline = new HoodieArchivedTimeline(this);
-    }
-    return archivedTimeline;
+  public synchronized HoodieArchivedTimeline getArchivedTimeline(String startTs, String endTs)
{
 
 Review comment:
   Any reason to remove `if (archivedTimeline == null)` check ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message