hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] nsivabalan commented on a change in pull request #1187: [HUDI-499] Allow update partition path with GLOBAL_BLOOM
Date Wed, 22 Jan 2020 13:40:04 GMT
nsivabalan commented on a change in pull request #1187: [HUDI-499] Allow update partition path
with GLOBAL_BLOOM
URL: https://github.com/apache/incubator-hudi/pull/1187#discussion_r369556733
 
 

 ##########
 File path: hudi-client/src/main/java/org/apache/hudi/config/HoodieIndexConfig.java
 ##########
 @@ -77,6 +77,17 @@
   public static final String BLOOM_INDEX_INPUT_STORAGE_LEVEL = "hoodie.bloom.index.input.storage.level";
   public static final String DEFAULT_BLOOM_INDEX_INPUT_STORAGE_LEVEL = "MEMORY_AND_DISK_SER";
 
+  /**
+   * Only applies if index type is GLOBAL_BLOOM.
+   * <p>
+   * When set to true, an update including the partition path of a record that already exists
will result in inserting
 
 Review comment:
   minor: "when set to true, an update to a record with diff partition compared to its existence,
will insert the record to new partition and delete from old partition. When set to false,
record will be updated to old partition". 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message