hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] leesf commented on a change in pull request #1237: [MINOR] Code Cleanup, remove redundant code, and other changes
Date Sat, 18 Jan 2020 01:38:55 GMT
leesf commented on a change in pull request #1237: [MINOR] Code Cleanup, remove redundant code,
and other changes
URL: https://github.com/apache/incubator-hudi/pull/1237#discussion_r368191728
 
 

 ##########
 File path: hudi-common/src/main/java/org/apache/hudi/common/util/FSUtils.java
 ##########
 @@ -198,7 +193,7 @@ public static String getRelativePartitionPath(Path basePath, Path partitionPath)
     return partitions;
   }
 
-  public static final List<String> getAllDataFilesForMarkers(FileSystem fs, String
basePath, String instantTs,
+  public static List<String> getAllDataFilesForMarkers(FileSystem fs, String basePath,
String instantTs,
 
 Review comment:
   ditto, any concerns?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message