hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] leesf commented on a change in pull request #1237: [MINOR] Code Cleanup, remove redundant code, and other changes
Date Sat, 18 Jan 2020 00:27:57 GMT
leesf commented on a change in pull request #1237: [MINOR] Code Cleanup, remove redundant code,
and other changes
URL: https://github.com/apache/incubator-hudi/pull/1237#discussion_r368187882
 
 

 ##########
 File path: hudi-common/src/main/java/org/apache/hudi/avro/MercifulJsonConverter.java
 ##########
 @@ -286,7 +284,7 @@ private static JsonToAvroFieldProcessor generateArrayTypeHandler() {
       public Pair<Boolean, Object> convert(Object value, String name, Schema schema)
           throws HoodieJsonToAvroConversionException {
         Schema elementSchema = schema.getElementType();
-        List listRes = new ArrayList();
+        List listRes = new ArrayList<>();
 
 Review comment:
   List<Object> listRes = new ArrayList<>(); ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message