hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] yanghua commented on issue #1239: [MINOR] Abstract a test case class for DFS Source to make it extensible
Date Fri, 17 Jan 2020 08:49:19 GMT
yanghua commented on issue #1239: [MINOR] Abstract a test case class for DFS Source to make
it extensible
URL: https://github.com/apache/incubator-hudi/pull/1239#issuecomment-575533263
 
 
   Hi @yihua thanks for your contribution. The thought looks good. After thinking deeply.
Can we define a top-level `AbstractDFSSourceTestBase` to do the abstraction? Then, we can
have `TestJsonDFSSource`, `TestParquetDFSSource` and `TestCsvDFSSource` to make the test more
extendable.
   
   IMHO, currently, the testing for the DFS source is not enough. We would add more test cases
to test more scenes in the future. Split different test cases of sources into different classes
is a good direction. WDYT?
   
   In addition, just a tip. The change may beyond the scope of the "MINOR". In the future,
I suggest we can create jira to track these refactor.
   
   > a "MINOR" should be a small(minor) change that needs not to be file in the jira. We
even may merge it before the Travis is green, If we are bold enough.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message