hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] vinothchandar commented on issue #1212: [HUDI-509] Renaming code in sync with cWiki restructuring
Date Fri, 17 Jan 2020 07:38:16 GMT
vinothchandar commented on issue #1212: [HUDI-509] Renaming code in sync with cWiki restructuring
URL: https://github.com/apache/incubator-hudi/pull/1212#issuecomment-575512172
 
 
   @bhasudha good catch. I cleaned up what you pointed out.. but there are still tons of variables
named `dataFile` instead of `baseFile`. I created a JIRA for later.. 
   
   @n3nash On the suffix, I believe this is the least path of change for existing users. I
believe most users will be using teh _rt table with MOR.. So we can't rename that or drop
the suffix there... Its better to add it to the RO table to make it clear.. I even added a
flag to hive sync so that existing users can skip _ro suffix if needed..
   
   Ideally we had no suffix on the snapshot table and only did a special _ro suffix... or
even drop the _ro talbe altogether.. but this is a much larger change.. We can pursue this
on top of what this PR does anyway 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message