hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] bhasudha commented on a change in pull request #1212: [HUDI-509] Renaming code in sync with cWiki restructuring
Date Thu, 16 Jan 2020 22:14:50 GMT
bhasudha commented on a change in pull request #1212: [HUDI-509] Renaming code in sync with
cWiki restructuring
URL: https://github.com/apache/incubator-hudi/pull/1212#discussion_r367678245
 
 

 ##########
 File path: hudi-common/src/main/java/org/apache/hudi/common/table/timeline/dto/DataFileDTO.java
 ##########
 @@ -36,22 +36,22 @@
   @JsonProperty("fileLen")
   private long fileLen;
 
-  public static HoodieDataFile toHoodieDataFile(DataFileDTO dto) {
+  public static HoodieBaseFile toHoodieDataFile(DataFileDTO dto) {
     if (null == dto) {
       return null;
     }
 
-    HoodieDataFile dataFile = null;
+    HoodieBaseFile dataFile = null;
     if (null != dto.fileStatus) {
-      dataFile = new HoodieDataFile(FileStatusDTO.toFileStatus(dto.fileStatus));
+      dataFile = new HoodieBaseFile(FileStatusDTO.toFileStatus(dto.fileStatus));
     } else {
-      dataFile = new HoodieDataFile(dto.fullPath);
+      dataFile = new HoodieBaseFile(dto.fullPath);
       dataFile.setFileLen(dto.fileLen);
     }
     return dataFile;
   }
 
-  public static DataFileDTO fromHoodieDataFile(HoodieDataFile dataFile) {
+  public static DataFileDTO fromHoodieDataFile(HoodieBaseFile dataFile) {
 
 Review comment:
   'fromHoodieBaseFile' instead ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message