hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] vinothchandar commented on issue #1208: [HUDI-304] Bring back spotless plugin
Date Tue, 14 Jan 2020 06:31:12 GMT
vinothchandar commented on issue #1208: [HUDI-304] Bring back spotless plugin
URL: https://github.com/apache/incubator-hudi/pull/1208#issuecomment-574024869
 
 
   >ocument that developers could use checkstyle.xml file in style folder in checkstyle
plugin and things will go well 
   
   I was able to use checkstyle to format in IntelliJ. This is fine.. but we should clearly
document this. maybe file a JIRA?
   
   On import order, we can take a second stab may be down the line? again filing a JIRA would
be great for tracking.. 
   
   On this PR, my concern was we are reformatting again due to the 120 character limit? I
was trying to see if we can avoid it. @leesf could you explain why 100+ files are being touched
in this PR? If these were all checkstyle failures, then master would be broken right? I am
just trying to understand what code really changed here, given we are close to a release..
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message