hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] leesf edited a comment on issue #1208: [HUDI-304] Bring back spotless plugin
Date Mon, 13 Jan 2020 02:53:31 GMT
leesf edited a comment on issue #1208: [HUDI-304] Bring back spotless plugin
URL: https://github.com/apache/incubator-hudi/pull/1208#issuecomment-573489191
 
 
   > I think most of the changes here are due to the 200 -> 120 line length change?
In the interest of not reformatting code back and forth, I think we should just keep `200`
. 200 is also a better practical value IMO. most modern displays can easily support 200 characters
without scroll..
   
   No the changes has nothing to do with changing lineLength to 120. 
   Sure, 200 is enough as explained above.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message