hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] sev7e0 commented on a change in pull request #1210: [HUDI-458] Redo hudi-hadoop-mr log statements using SLF4J
Date Mon, 13 Jan 2020 02:24:23 GMT
sev7e0 commented on a change in pull request #1210: [HUDI-458] Redo hudi-hadoop-mr log statements
using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1210#discussion_r365631918
 
 

 ##########
 File path: hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/realtime/HoodieParquetRealtimeInputFormat.java
 ##########
 @@ -226,9 +226,9 @@ private static Configuration cleanProjectionColumnIds(Configuration conf)
{
     // actual heavy lifting of reading the parquet files happen.
     if (job.get(HOODIE_READ_COLUMNS_PROP) == null) {
       synchronized (job) {
-        LOG.info(
-            "Before adding Hoodie columns, Projections :" + job.get(ColumnProjectionUtils.READ_COLUMN_NAMES_CONF_STR)
-                + ", Ids :" + job.get(ColumnProjectionUtils.READ_COLUMN_IDS_CONF_STR));
+        LOG.info("Before adding Hoodie columns, Projections : {}, Ids : {}",
+                job.get(ColumnProjectionUtils.READ_COLUMN_NAMES_CONF_STR),
+                job.get(ColumnProjectionUtils.READ_COLUMN_IDS_CONF_STR));
 
 Review comment:
   I think the auto indent was brought by `idea`. drop it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message