hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] hddong commented on a change in pull request #1157: [HUDI-332]Add operation type (insert/upsert/bulkinsert/delete) to HoodieCommitMetadata
Date Mon, 13 Jan 2020 01:31:39 GMT
hddong commented on a change in pull request #1157: [HUDI-332]Add operation type (insert/upsert/bulkinsert/delete)
to HoodieCommitMetadata
URL: https://github.com/apache/incubator-hudi/pull/1157#discussion_r365628090
 
 

 ##########
 File path: hudi-common/src/main/avro/HoodieCommitMetadata.avsc
 ##########
 @@ -129,6 +129,11 @@
          }],
          "default": null
       },
+      {
 
 Review comment:
   > is nt that need for this to be backwards compatible
   
   Move it to the end. IMO, it has no impact on compatibility.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message