hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] n3nash commented on a change in pull request #1194: [HUDI-326] Add support to delete records with only record_key
Date Tue, 07 Jan 2020 01:11:37 GMT
n3nash commented on a change in pull request #1194: [HUDI-326] Add support to delete records
with only record_key
URL: https://github.com/apache/incubator-hudi/pull/1194#discussion_r363554003
 
 

 ##########
 File path: hudi-client/src/main/java/org/apache/hudi/index/HoodieIndex.java
 ##########
 @@ -43,6 +44,8 @@
  */
 public abstract class HoodieIndex<T extends HoodieRecordPayload> implements Serializable
{
 
+  public static EnumSet<IndexType> GLOBAL_INDICES = EnumSet.of(IndexType.GLOBAL_BLOOM,
IndexType.HBASE);
 
 Review comment:
   This is not very desirable since this is only required for deletion purposes and does not
add any other value. Each implementation of the Index already has a method that describes
whether it's global or not. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message