hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] dengziming commented on a change in pull request #1185: [HUDI-500] Use enum method to replace switch case
Date Sun, 05 Jan 2020 07:34:05 GMT
dengziming commented on a change in pull request #1185: [HUDI-500] Use enum method to replace
switch case
URL: https://github.com/apache/incubator-hudi/pull/1185#discussion_r363074791
 
 

 ##########
 File path: hudi-common/src/main/java/org/apache/hudi/common/model/HoodieTableType.java
 ##########
 @@ -32,5 +36,62 @@
  * SIMPLE_LSM - A simple 2 level LSM tree.
  */
 public enum HoodieTableType {
-  COPY_ON_WRITE, MERGE_ON_READ
 
 Review comment:
   hello, do you mean adding comment of `COPY_ON_WRITE` and `MERGE_ON_READ` or move original
comment of these methods to the new methods?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message