hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] yanghua commented on a change in pull request #1161: [HUDI-457]Redo hudi-common log statements using SLF4J
Date Thu, 02 Jan 2020 03:20:49 GMT
yanghua commented on a change in pull request #1161: [HUDI-457]Redo hudi-common log statements
using SLF4J
URL: https://github.com/apache/incubator-hudi/pull/1161#discussion_r362357721
 
 

 ##########
 File path: hudi-common/src/main/java/org/apache/hudi/common/model/HoodiePartitionMetadata.java
 ##########
 @@ -101,8 +101,8 @@ public void trySave(int taskPartitionId) {
         fs.rename(tmpMetaPath, metaPath);
       }
     } catch (IOException ioe) {
-      LOG.warn("Error trying to save partition metadata (this is okay, as long as atleast
1 of these succced), "
-          + partitionPath, ioe);
+      LOG.warn(String.format("Error trying to save partition metadata (this is okay, as long
as atleast 1 of these "
 
 Review comment:
   Since we have used slf4j, we may not need to use `String.format`. The slf4j framework supports
`placeholder`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message