From test-dev-return-3943-apmail-httpd-test-dev-archive=httpd.apache.org@httpd.apache.org Thu Nov 10 10:34:23 2005 Return-Path: Delivered-To: apmail-httpd-test-dev-archive@www.apache.org Received: (qmail 5895 invoked from network); 10 Nov 2005 10:34:23 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 10 Nov 2005 10:34:23 -0000 Received: (qmail 37530 invoked by uid 500); 10 Nov 2005 10:34:22 -0000 Delivered-To: apmail-httpd-test-dev-archive@httpd.apache.org Received: (qmail 37510 invoked by uid 500); 10 Nov 2005 10:34:22 -0000 Mailing-List: contact test-dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: test-dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list test-dev@httpd.apache.org Received: (qmail 37496 invoked by uid 99); 10 Nov 2005 10:34:22 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Nov 2005 02:34:22 -0800 X-ASF-Spam-Status: No, hits=0.5 required=10.0 tests=DNS_FROM_RFC_ABUSE X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [66.163.179.181] (HELO web35812.mail.mud.yahoo.com) (66.163.179.181) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 10 Nov 2005 02:34:15 -0800 Received: (qmail 82422 invoked by uid 60001); 10 Nov 2005 10:34:00 -0000 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=Message-ID:Received:Date:From:Subject:To:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=zeGtmwl0WNdQ4+Cfm8rIhRrT1RtWcftoEiTHabGKOm6Bie7+RmBCIea97Ew3yRFwA96h43deDy/VB8EPGKklkQ0MAmTX0eISN186L1nA+jZ/xVbGAmk4+/2tpUJu2zR8I9CcGiQSHyXJ2BzvgFr6V6xTPnfj0vMFcJlcwf+PrBs= ; Message-ID: <20051110103400.82420.qmail@web35812.mail.mud.yahoo.com> Received: from [69.225.174.130] by web35812.mail.mud.yahoo.com via HTTP; Thu, 10 Nov 2005 02:34:00 PST Date: Thu, 10 Nov 2005 02:34:00 -0800 (PST) From: Zubin Kika Subject: Re: Perl framework patch for Apache bug 37145 To: test-dev@httpd.apache.org In-Reply-To: <20051110102458.55525.qmail@web35802.mail.mud.yahoo.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="0-97231640-1131618840=:81588" Content-Transfer-Encoding: 8bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N --0-97231640-1131618840=:81588 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Content-Id: Content-Disposition: inline Don't know why the other file didn't make it. Attaching pr37145.t again. Zubin --- Zubin Kika wrote: > Hi, > > Thank you Joe for your suggestions. > I have incorporated the changes and attached two > files: > 1)pr37145.t: This file is to be placed in > t/ssl/ > 2)testrev_proxy.pl: This file is to be > placed > in t/htdocs/modules/cgi/ > > Please review. > > With regards, > Zubin > > --- Joe Orton wrote: > > > On Wed, Oct 26, 2005 at 01:30:22AM -0700, Zubin > Kika > > wrote: > > > The patch is attached. > > > It contains the following files: > > > t/ssl/proxy_bug37145.t :The script file > > > t/htdocs/test.txt :Test file of size 100Kb > > > t/htdocs/test1.txt :Test file of size less than > 8 > > Kb > > > t/htdocs/test2.txt :Test file of size 8Kb > > > t/htdocs/modules/cgi/testrev_proxy.pl :Perl file > > that > > > will handle the posted data > > > > > > Request you to please review the same. > > > > Thanks for the contribution. > > > > - the CGI script should not rely on CGI.pm > > - call the new test simply "t/ssl/pr37145.t" > > - attach files not tarballs when posting new code > > - create a new directory for new htdocs > > (t/htdocs/modules/ssl) > > - a CGI script which outputs 100Kb of data would > be > > preferable to > > adding a 100Kb file directly to the repos > > - follow the normal code style (indenting, > > whitespace etc) for the .t > > code; should be something like: > > > http://perl.apache.org/docs/2.0/devel/core/coding_style.html#Coding_Style_Guide > > > > joe > > > > > > > __________________________________ > Yahoo! Mail - PC Magazine Editors' Choice 2005 > http://mail.yahoo.com __________________________________ Yahoo! FareChase: Search multiple travel sites in one click. http://farechase.yahoo.com --0-97231640-1131618840=:81588--