Mailing-List: contact test-dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: test-dev@httpd.apache.org
Received-SPF: pass (asf.osuosl.org: domain of jorton@redhat.com designates
 66.187.233.31 as permitted sender)
Date: Wed, 26 Oct 2005 13:12:02 +0100
From: Joe Orton <jorton@redhat.com>
To: test-dev@httpd.apache.org
Subject: Re: Perl framework patch for Apache bug 37145
Message-ID: <20051026121202.GA2245@redhat.com>
Mail-Followup-To: test-dev@httpd.apache.org
References: <435BE862.1090809@stason.org>
 <20051026083022.15067.qmail@web35804.mail.mud.yahoo.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20051026083022.15067.qmail@web35804.mail.mud.yahoo.com>
User-Agent: Mutt/1.4.2.1i

On Wed, Oct 26, 2005 at 01:30:22AM -0700, Zubin Kika wrote:
> The patch is attached.
> It contains the following files:
> t/ssl/proxy_bug37145.t :The script file
> t/htdocs/test.txt :Test file of size 100Kb
> t/htdocs/test1.txt :Test file of size less than 8 Kb
> t/htdocs/test2.txt :Test file of size 8Kb
> t/htdocs/modules/cgi/testrev_proxy.pl :Perl file that
> will handle the posted data
> 
> Request you to please review the same.

Thanks for the contribution.

- the CGI script should not rely on CGI.pm
- call the new test simply "t/ssl/pr37145.t"
- attach files not tarballs when posting new code
- create a new directory for new htdocs (t/htdocs/modules/ssl)
- a CGI script which outputs 100Kb of data would be preferable to 
adding a 100Kb file directly to the repos
- follow the normal code style (indenting, whitespace etc) for the .t 
code; should be something like:
http://perl.apache.org/docs/2.0/devel/core/coding_style.html#Coding_Style_Guide
 
joe