httpd-test-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philip M. Gollucci" <>
Subject Re: [PATCH] fix mp2bug output to find httpd correct
Date Fri, 09 Sep 2005 17:13:03 GMT

> It's too risky to just check for Makefile.PL, since it's too generic. 
> What if someone decides to run mp2bug while residing in the source 
> directory of some other perl distro? How about:
> use constant IS_MOD_PERL_BUILD => grep
>     { -e "$_/Makefile.PL" && -e "$_/lib/" } qw(. ..);
I agree that its probably too generic but anything short of them copying
mp2bug into
other-distro/bin or other-distro wouldn't cause it to break.
I like you're idea better though, as it account for the above case too.


> not really, I believe. It's possible that -httpd is not passed, in which 
> case this won't work.
I've yet to pass -httpd to anything other then Apache2::DebugFilter.

Thats okay, I liked the first one better anyway.

     What doesn't kill us can only make us stronger.
                 Nothing is impossible.
Philip M. Gollucci ( 301.254.5198
Consultant /
Senior Developer / Liquidity Services, Inc.

View raw message