httpd-test-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philip M. Gollucci" <pgollu...@p6m7g8.com>
Subject Re: [PATCH] fix mp2bug output to find httpd correct
Date Fri, 09 Sep 2005 17:13:03 GMT

> It's too risky to just check for Makefile.PL, since it's too generic. 
> What if someone decides to run mp2bug while residing in the source 
> directory of some other perl distro? How about:
> 
> use constant IS_MOD_PERL_BUILD => grep
>     { -e "$_/Makefile.PL" && -e "$_/lib/mod_perl2.pm" } qw(. ..);
I agree that its probably too generic but anything short of them copying
mp2bug into
other-distro/bin or other-distro wouldn't cause it to break.
I like you're idea better though, as it account for the above case too.

+1



> not really, I believe. It's possible that -httpd is not passed, in which 
> case this won't work.
I've yet to pass -httpd to anything other then Apache2::DebugFilter.
:)

Thats okay, I liked the first one better anyway.

-- 
END
------------------------------------------------------------
     What doesn't kill us can only make us stronger.
                 Nothing is impossible.
				
Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/
Senior Developer / Liquidity Services, Inc.
   http://www.liquidityservicesinc.com
        http://www.liquidation.com
        http://www.uksurplus.com
        http://www.govliquidation.com
        http://www.gowholesale.com


Mime
View raw message