httpd-test-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher H. Laco" <cl...@chrislaco.com>
Subject Re: [PATCH] module2path/module2url pod
Date Wed, 08 Dec 2004 13:57:36 GMT
Stas Bekman wrote:
> Christopher H. Laco wrote:
> 
>> Here's my first crack at pod for module2path and module2url.
>> I decided to put it at the end of the FUNCTONS head1. It didn't seem 
>> to make much sense at the beginning and it felt like I should keep 
>> focus on the exported functions.
> 
> 
> There is already one head1 FUNCTIONS there.
> 
> I've called your header:
> 
>   =head2 URL Manipulation Functions
> 
> since all function in this module are 'helper functions' :)
> 
>> Let me know if you had something else in mind and I'll rework it.
> 
> 
> Looks good. I've massaged it a bit and commited.
> 
> Thanks Chris.
> 
Shouldn't that be:

Index: TestRequest.pm
===================================================================
--- TestRequest.pm	(revision 111269)
+++ TestRequest.pm	(working copy)
@@ -1121,7 +1121,7 @@
  =head3 C<module2url>

    $url = Apache::TestRequest::module2url($module);
-  $url = Apache::TestRequest::module2url($module, %options);
+  $url = Apache::TestRequest::module2url($module, \%options);

  Convert a module name to a full URL including the current
  configurations C<hostname:port> and sets C<module> accordingly.


Maybe it's just me. The former leads me to believe that I might be able 
to do:
	module2url('MyMod::Test',
		scheme => 'https', path => '/merge3/');
instead of
	module2url('MyMod::Test',
		{scheme => 'https', path => '/merge3/'});
while the later make that more clear.

Any other grunt work can work on?
-=Chris

Mime
View raw message