httpd-test-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Christopher H. Laco" <apache-t...@chrislaco.com>
Subject Re: [PATCH] Test & TestRequest pod
Date Thu, 02 Dec 2004 13:55:17 GMT
Stas Bekman wrote:
> Christopher H. Laco wrote:
> 
>> OK, I'm a programmer, not a writer. Be gentle.
>> Nothing major, just the a mention of cookie_jar and additional headers 
>> via the second param in GET (and probably others?).
>>
>> While I was at it, I made sure all of the need* examples were all the 
>> same; which meant removing \& and &. The bare versions seemed to be 
>> the most prevelant.
> 
> 
> Thanks Chris, commited. But see below.
> 
> Also in the future please try to post diffs against the root of the 
> project so it's easier to apply those. Thanks.

I assume you mean http://svn.apache.org/repos/asf/httpd/test/trunk/, and 
not just the root of Apache-Test correct?

> 
>> Index: TestRequest.pm
>> +  Apache::TestRequest::user_agent(reset =>,
>> +                                  cookie_jar => {});
> 
> 
> Sorry, but what's that 'reset => ' thing? I've committed just:
> 
>   Apache::TestRequest::user_agent(cookie_jar => {});
> 
> as in the test.

Geez. Apparently I'm in the clouds this week. Maybe I need to do these 
changes during the day instead of at night. :-/

> 
>>  =head1 FUNCTIONS
>>  
>>  C<Apache::TestRequest> exports a number of functions that will likely
>> @@ -837,6 +850,11 @@
>>  Sends a simple GET request to the Apache test server. Returns an
>>  C<HTTP::Response> object.
>>  
>> +You can also supply additional headers to be sent with the request
>> +by adding their name/value pairs after the C<url> parameter:
> 
> 
> really it's a dup of the more extensive docs at:
> http://perl.apache.org/docs/general/testing/testing.html#Request_and_Response_Methods


Well, yes, and that was on purpose. I hated reading the A-T pod and 
never knowing there was an extra param for GET. THe pod usualy is enough 
to get start, and I wouldn't exptec to have to read:

http://perl.apache.org/docs/general/testing/testing.html#Request_and_Response_Methods 


Were you looking for something more extensive?

> 
> but committed anyway :)
> 


Mime
View raw message