Mailing-List: contact test-dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: test-dev@httpd.apache.org
Received-SPF: pass (hermes.apache.org: local policy)
Message-ID: <4151F2C1.4050106@stason.org>
Date: Wed, 22 Sep 2004 17:46:41 -0400
From: Stas Bekman <stas@stason.org>
Organization: Hope, Humanized
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.2) Gecko/20040804
MIME-Version: 1.0
To: test-dev@httpd.apache.org
Subject: Re: -one-process configuration option
References: <4150DC71.4080303@modperlcookbook.org>
In-Reply-To: <4150DC71.4080303@modperlcookbook.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Geoffrey Young wrote:
> hi all...
> 
> I've found it necessary to toggle single server mode when using Apache-Test,
> specifically for getting Devel::Cover to work with mod_perl 1.0 nicely.  so,
> I'd like to add an option for switching back to single server mode on demand
> for a normal run.
> 
> the problem is that TestServer, which controls how the server is started,
> does not have access to TestRun parsed configuration options.  TestServer
> has access to TestConfig options, but all of those take arguments and
> persist until the next time you run -clean, which isn't desirable.
> 
> we've run into this issue before, wanting to give TestServer access to
> per-run directives, but we never really had a decent solution.  this one
> just adds an Apache::TestRun object to the Apache::TestServer hash at the
> appropriate times, which TestServer can then use if it so chooses.  other
> solutions welcome.

+1, with the style fix below:

> Index: Apache/TestServer.pm

> +    my $one_process = $self->{run}->{opts}->{'one-process'} ? 
> +                      $self->version_of(\%one_process)      : 
> +                      '';

should be:

  my $one_process = $self->{run}->{opts}->{'one-process'}
      ? $self->version_of(\%one_process)
      : '';


-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com