httpd-test-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Geoffrey Young <ge...@modperlcookbook.org>
Subject Re: cvs commit: httpd-test/perl-framework/t/protocol nntp-like.t
Date Thu, 30 Sep 2004 13:56:33 GMT


Justin Erenkrantz wrote:
> --On Wednesday, September 29, 2004 10:26 AM +0100 Joe Orton
> <jorton@redhat.com> wrote:
> 
>> Yup, the t_cmp arguments were flipped a while back.
> 
> 
> FWIW, I think whomever flipped the t_cmp arguments but didn't flip the
> included test cases at the same time needs a stern talking to.  I spent
> over an hour and a half figuring out why the heck httpd was returning a
> 200 in that case where a 413 was clearly (or at least more) correct:
> only to find out that the debug output was swapped.  Incredibly,
> incredibly lame.

yeah, well, that was me.  it's difficult to find the time to do everything
that needs doing.  in this case, the order was swapped to be consistent with
 other (more popular) Perl testing libraries, but there just weren't enough
tuits lying around to make all the changes throughout the perl-framework.
the argument at the time was that this was OK(tm) because the only thing
affected was the debugging output, not the actual comparison.  I'll take the
blame for that brain fart too, but again a severe lack of free time got in
the way of doing things a bit better.

however, those of us that are reasonably active here were aware of this, uh,
issue and were changing test files as we touched them for other reasons.

so yeah, it sucks, continues to suck, and I'm sorry.  I'll buy you a beer or
two at apachecon to make up for it :)

--Geoff

Mime
View raw message