httpd-test-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: cvs commit: httpd-test/perl-framework/t/protocol nntp-like.t
Date Wed, 29 Sep 2004 14:39:55 GMT
On Wed, Sep 29, 2004 at 10:26:05AM +0100, Joe Orton wrote:
> On Wed, Sep 29, 2004 at 06:53:42AM -0000, jerenkrantz@apache.org wrote:
> > jerenkrantz    2004/09/28 23:53:42
> > 
> >   Modified:    perl-framework/c-modules/nntp_like mod_nntp_like.c
> >                perl-framework/t/apache contentlength.t
> >                perl-framework/t/protocol nntp-like.t
> >   Log:
> >   Fix up nntp-like and content-length tests to pass.
> 
> To pass against what httpd on what platform? They were passing on Linux
> against 2.0 and HEAD.  But now they're not :) Against HEAD I now get:

OK, the difference is in the handling of an empty Content-Length header. 
The glibc strtoll does not return an error for an empty string, as C99
requires, and so ap_http_filter treats it exactly as "Content-Length:
0".

I guess the strto* on your platform does return an error for this case:
I'd say a 400 is a better error than a 413 for "Content-Length:\r\n" but
413 is clearly better than 200, so I've fixed ap_http_filter in HEAD.

joe

Mime
View raw message