From test-dev-return-3236-apmail-httpd-test-dev-archive=httpd.apache.org@httpd.apache.org Wed Aug 18 09:01:42 2004 Return-Path: Delivered-To: apmail-httpd-test-dev-archive@www.apache.org Received: (qmail 14400 invoked from network); 18 Aug 2004 09:01:42 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 18 Aug 2004 09:01:42 -0000 Received: (qmail 69147 invoked by uid 500); 18 Aug 2004 09:01:41 -0000 Delivered-To: apmail-httpd-test-dev-archive@httpd.apache.org Received: (qmail 69095 invoked by uid 500); 18 Aug 2004 09:01:40 -0000 Mailing-List: contact test-dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: test-dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list test-dev@httpd.apache.org Received: (qmail 69081 invoked by uid 99); 18 Aug 2004 09:01:40 -0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received: from [66.187.233.31] (HELO mx1.redhat.com) (66.187.233.31) by apache.org (qpsmtpd/0.27.1) with ESMTP; Wed, 18 Aug 2004 02:01:37 -0700 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.10/8.12.10) with ESMTP id i7I91Ze1015073 for ; Wed, 18 Aug 2004 05:01:35 -0400 Received: from radish.cambridge.redhat.com (radish.cambridge.redhat.com [172.16.18.90]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i7I91Za25473 for ; Wed, 18 Aug 2004 05:01:35 -0400 Received: from radish.cambridge.redhat.com (localhost.localdomain [127.0.0.1]) by radish.cambridge.redhat.com (8.12.10/8.12.7) with ESMTP id i7I91YHP004783 for ; Wed, 18 Aug 2004 10:01:34 +0100 Received: (from jorton@localhost) by radish.cambridge.redhat.com (8.12.10/8.12.10/Submit) id i7I91X1Y004782 for test-dev@httpd.apache.org; Wed, 18 Aug 2004 10:01:33 +0100 Date: Wed, 18 Aug 2004 10:01:32 +0100 From: Joe Orton To: test-dev@httpd.apache.org Subject: shell_ready function Message-ID: <20040818090132.GA4166@redhat.com> Mail-Followup-To: test-dev@httpd.apache.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline User-Agent: Mutt/1.4.1i X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Does the quote escaping really work in this function? It confuses emacs font-lock mode which doesn't see a closing quote so thinks the rest of the file is part of the string. This fixes at least the latter: Index: TestConfig.pm =================================================================== RCS file: /home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestConfig.pm,v retrieving revision 1.239 diff -u -r1.239 TestConfig.pm --- TestConfig.pm 15 Aug 2004 23:19:57 -0000 1.239 +++ TestConfig.pm 18 Aug 2004 08:55:29 -0000 @@ -1754,7 +1754,7 @@ # escape quotes) sub shell_ready { my $arg = shift; - $arg =~ s/"/\"/g; + $arg =~ s/"/\\"/g; return qq["$arg"]; }