httpd-test-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: failing httpd-test tests
Date Tue, 10 Aug 2004 21:14:10 GMT
On Tue, Aug 10, 2004 at 09:56:12AM -0700, Stas Bekman wrote:
> Aha! Excellent, Geoff! Does it solve the problem by moving those 
> default_module calls after getting httpd config?

Moving the calls one line further on fixed it for me.  OK to check in? 
(BTW your patch had whitespace issues and only applied with patch -l)

Index: Apache-Test/lib/Apache/TestConfig.pm
===================================================================
RCS file: /home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestConfig.pm,v
retrieving revision 1.235
diff -u -r1.235 TestConfig.pm
--- Apache-Test/lib/Apache/TestConfig.pm	9 Aug 2004 06:19:15 -0000	1.235
+++ Apache-Test/lib/Apache/TestConfig.pm	10 Aug 2004 21:12:59 -0000
@@ -313,13 +313,6 @@
     $vars->{proxyssl_url} ||= '';
     $vars->{defines}      ||= '';
 
-    $self->default_module(cgi    => [qw(mod_cgi mod_cgid)]);
-    $self->default_module(thread => [qw(worker threaded)]);
-    $self->default_module(ssl    => [qw(mod_ssl)]);
-    $self->default_module(access => [qw(mod_access mod_authz_host)]);
-    $self->default_module(auth   => [qw(mod_auth mod_auth_basic)]);
-    $self->default_module(php    => [qw(mod_php4 mod_php5)]);
-
     $self->{hostport} = $self->hostport;
     $self->{server} = $self->new_test_server;
 
@@ -359,6 +352,14 @@
     }
 
     $self->inherit_config; #see TestConfigParse.pm
+
+    $self->default_module(cgi    => [qw(mod_cgi mod_cgid)]);
+    $self->default_module(thread => [qw(worker threaded)]);
+    $self->default_module(ssl    => [qw(mod_ssl)]);
+    $self->default_module(access => [qw(mod_access mod_authz_host)]);
+    $self->default_module(auth   => [qw(mod_auth mod_auth_basic)]);
+    $self->default_module(php    => [qw(mod_php4 mod_php5)]);
+
     $self->configure_httpd_eapi; #must come after inherit_config
 
     $self->{server}->post_config;

Mime
View raw message