httpd-test-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: cvs commit: httpd-test/perl-framework/t/apache errordoc.t
Date Fri, 16 Jul 2004 12:17:38 GMT
On Mon, Jul 12, 2004 at 05:03:50PM -0000, geoff@apache.org wrote:
>   --- errordoc.t	12 Jul 2004 16:44:47 -0000	1.2
>   +++ errordoc.t	12 Jul 2004 17:03:49 -0000	1.3
>   @@ -59,8 +59,7 @@
>                 '/redefine/notfound.html code');
>    
>        # 1.3 requires quotes for hard-coded messages
>   -    my $expected = have_min_apache_version('2.1') ? qr/Not Found/ : 
>   -                   have_apache(2)                 ? 'default'     :
>   +    my $expected = have_apache(2) ? qr/Not Found/ : 
>                       qr/Additionally, a 500/;
>    

This makes the test fail against 2.0.50, but it's just a lack-of-feature
right, so OK if I half-revert this?

--- t/apache/errordoc.t	12 Jul 2004 17:03:49 -0000	1.3
+++ t/apache/errordoc.t	16 Jul 2004 12:16:25 -0000
@@ -59,7 +59,8 @@
              '/redefine/notfound.html code');
 
     # 1.3 requires quotes for hard-coded messages
-    my $expected = have_apache(2) ? qr/Not Found/ : 
+    my $expected = have_min_apache_version('2.0.51') ? qr/Not Found/ :
+                   have_apache(2)                    ? 'default' : 
                    qr/Additionally, a 500/;
 
     ok t_cmp($content,

Mime
View raw message