Return-Path: Delivered-To: apmail-httpd-test-dev-archive@www.apache.org Received: (qmail 21942 invoked from network); 5 May 2004 23:41:12 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 5 May 2004 23:41:12 -0000 Received: (qmail 34699 invoked by uid 500); 5 May 2004 23:40:57 -0000 Delivered-To: apmail-httpd-test-dev-archive@httpd.apache.org Received: (qmail 34673 invoked by uid 500); 5 May 2004 23:40:57 -0000 Mailing-List: contact test-dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: test-dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list test-dev@httpd.apache.org Received: (qmail 34650 invoked from network); 5 May 2004 23:40:56 -0000 Received: from unknown (HELO mail.logilune.com) (195.154.174.52) by daedalus.apache.org with SMTP; 5 May 2004 23:40:56 -0000 Received: from stason.org (localhost.logilune.com [127.0.0.1]) by mail.logilune.com (Postfix) with ESMTP id 5C7631E19A3 for ; Thu, 6 May 2004 01:41:03 +0200 (CEST) Message-ID: <40997B8E.10706@stason.org> Date: Wed, 05 May 2004 16:41:02 -0700 From: Stas Bekman Organization: Hope, Humanized User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040115 X-Accept-Language: en-us, en, he, ru MIME-Version: 1.0 To: test-dev@httpd.apache.org Subject: Re: digging out the missing error message References: <40993F4E.9070702@modperlcookbook.org> <40994835.80408@stason.org> <409952D3.6090601@modperlcookbook.org> <40996E47.10504@stason.org> <40996F5C.7050905@modperlcookbook.org> <4099759F.6040800@stason.org> <409979BF.4060408@modperlcookbook.org> In-Reply-To: <409979BF.4060408@modperlcookbook.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Geoffrey Young wrote: >>For example this >>does the trick: >> >>Index: Apache-Test/lib/Apache/TestRun.pm >>=================================================================== >>RCS file: >>/home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestRun.pm,v >>retrieving revision 1.166 >>diff -u -r1.166 TestRun.pm >>--- Apache-Test/lib/Apache/TestRun.pm 16 Apr 2004 20:29:23 -0000 >>1.166 >>+++ Apache-Test/lib/Apache/TestRun.pm 5 May 2004 23:15:14 -0000 >>@@ -347,6 +347,7 @@ >> >> $SIG{__DIE__} = sub { >> return unless $_[0] =~ /^Failed/i; #dont catch Test::ok failures >>+ print $_[0] if (caller(1))[3]||'' eq >>'Test::Harness::_show_results'; >> $server->stop(1) if $opts->{'start-httpd'}; >> $server->failed_msg("error running tests"); >> exit_perl 0; > > > either version is fine with me. this one is probably safer, though, as it > means we probably won't break stuff we don't know about. > > feel free to commit whichever version you prefer. it will be nice to have > this minor nit finally fixed :) Since you've researched it, I'll leave that to you :) I did the easy part. I agree with using the above version. but probably add a comment to why we do that strange matching. -- __________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:stas@stason.org http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com