httpd-test-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: digging out the missing error message
Date Wed, 05 May 2004 23:41:02 GMT
Geoffrey Young wrote:
>>For example this
>>does the trick:
>>
>>Index: Apache-Test/lib/Apache/TestRun.pm
>>===================================================================
>>RCS file:
>>/home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestRun.pm,v
>>retrieving revision 1.166
>>diff -u -r1.166 TestRun.pm
>>--- Apache-Test/lib/Apache/TestRun.pm   16 Apr 2004 20:29:23 -0000     
>>1.166
>>+++ Apache-Test/lib/Apache/TestRun.pm   5 May 2004 23:15:14 -0000
>>@@ -347,6 +347,7 @@
>>
>>     $SIG{__DIE__} = sub {
>>         return unless $_[0] =~ /^Failed/i; #dont catch Test::ok failures
>>+        print $_[0] if (caller(1))[3]||'' eq
>>'Test::Harness::_show_results';
>>         $server->stop(1) if $opts->{'start-httpd'};
>>         $server->failed_msg("error running tests");
>>         exit_perl 0;
> 
> 
> either version is fine with me.  this one is probably safer, though, as it
> means we probably won't break stuff we don't know about.
> 
> feel free to commit whichever version you prefer.  it will be nice to have
> this minor nit finally fixed :)

Since you've researched it, I'll leave that to you :) I did the easy part. I 
agree with using the above version. but probably add a comment to why we do 
that strange matching.


-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

Mime
View raw message