httpd-test-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestConfigPerl.pm
Date Wed, 28 Apr 2004 18:07:21 GMT
geoff@apache.org wrote:
> geoff       2004/04/28 07:55:42
> 
>   Modified:    perl-framework/Apache-Test/lib/Apache TestConfigPerl.pm
>   Log:
>   prevent 'Empty compile time value given to use lib' warnings
>   
>   Revision  Changes    Path
>   1.88      +1 -0      httpd-test/perl-framework/Apache-Test/lib/Apache/TestConfigPerl.pm
>   
>   Index: TestConfigPerl.pm
>   ===================================================================
>   RCS file: /home/cvs/httpd-test/perl-framework/Apache-Test/lib/Apache/TestConfigPerl.pm,v
>   retrieving revision 1.87
>   retrieving revision 1.88
>   diff -u -r1.87 -r1.88
>   --- TestConfigPerl.pm	7 Apr 2004 21:51:36 -0000	1.87
>   +++ TestConfigPerl.pm	28 Apr 2004 14:55:42 -0000	1.88
>   @@ -180,6 +180,7 @@
>            my $include_pl = catfile $self->{vars}->{t_conf}, 'modperl_inc.pl';
>            my $fh = $self->genfile($include_pl);
>            for (reverse @$inc) {
>   +            next unless $_;
>                print $fh "use lib '$_';\n";
>            }
>            my $fixup = Apache::TestConfig->modperl_2_inc_fixup();

I don't understand why did you have this problem (what did you have in @INC?), 
but I think that this just works around the problem. It's better to go up to 
where $self->{inc} is getting set and not let invalid values in, so if you use 
$self->{inc} you won't have to workaround again.


-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

Mime
View raw message