httpd-test-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestServer.pm
Date Fri, 05 Mar 2004 09:55:59 GMT
Geoffrey Young wrote:
>>> $ENV{APACHE_TEST_STARTUP_TIMEOUT} now supersedes -startup_timeout
>>>[...]
>>
>>
>>What's the reason for this change? 
> 
> 
> it was a follow up from something on modperl@
> 
> 
>>I almost always expect that command
>>line arguments supercede env variables.. i.e.
>>
>>$> CVSROOT=foo cvs -d bar co foo
>>Bad CVSROOT: `bar'.
>>
>>What you can see should win over what you can't see, IMO
> 
> 
> yeah, I thought about this after committing it - it's definitely better the
> way it was.  but it leaves mod_perl users in a lurch if they want to up the
> startup time.  the better solution is probably to have ModPerl::TestRun look
> at %ENV before it sets the startup timeout.
> 
> I'll fit that tomorrow unless you or stas beat me to it.

I've committed that change already. But I'll leave it to you to revert the one 
you committed ;)

-- 
__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

Mime
View raw message