httpd-test-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <>
Subject Re: new one: rwrite on aix with 1.3
Date Tue, 02 Mar 2004 23:09:47 GMT
Rodent of Unusual Size wrote:
> Stas Bekman wrote:
>>What assumption are you talking about? Using '/'? so your change is to use 
> yes.  is good?  or no?

It depends: If the path is only ever handled internally by perl than you can 
always use '/' and it will do the right thing on any platform. When it 
interacts with external world than nothing is sure.

So, yes, it's always a good idea to use catfile when building a path with a 
file, and catdir when it's only a directory path.

But be careful when that path is then used as a part of URI in which case 
http://example/foo\bar won't make a happy URI since it may live on a non-win32 
server, when the client is win32. But you know that already. This is just 
something I had tripped over several times.

So yes, your change is good and if you would like to fix the main function, 
that would be great.

Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker     mod_perl Guide --->

View raw message