httpd-test-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: [PATCH] fix @INC when running all.t
Date Fri, 27 Feb 2004 19:01:47 GMT
Rodent of Unusual Size wrote:
> Joe Orton wrote:
> 
>>>my $lib = catfile Apache::Test::vars('top_dir'), qw(Apache-Test lib);
>>>my $cmd = "$^X -Mlib=$lib $file";
> 
> 
> i don't think catfile does things like space-escaping, so wouldn't
> 
> my $lib = catfile Apache::Test::vars('top_dir'), qw(Apache-Test lib);
> my $cmd = "$^X -Mlib=\"$lib\" $file";
> 
> be better for things that might be in (for instance) "C:\Program Files\foo" ?

Good thinking, Ken. Please commit that change.

Though backslashism is not nice. Better write:

my $cmd = qq[$^X -Mlib="$lib" $file];

Thanks.

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

Mime
View raw message