httpd-test-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <s...@stason.org>
Subject Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache TestServer.pm
Date Tue, 24 Feb 2004 20:49:34 GMT
Geoffrey Young wrote:
>>   sub config_defines {
>>  +    my $self = shift;
>>  +
>>       my @defines = ();
>>   
>>       for my $item (qw(useithreads)) {
>>  @@ -88,7 +90,9 @@
>>           push @defines, "-DPERL_\U$item";
>>       }
>>   
>>  -    push @defines, map { "-D$_" } split " ", shift->{config}->{vars}->{defines};
>>  +    if (my $defines = $self->{config}->{vars}->{defines}) {
>>  +        push @defines, map { "-D$_" } split " ", $defines;
>>  +    }
>>   
>>       "@defines";
>>   }
> 
> 
> were you seeing specific undef warnings?  I ran it with and without the
> -defines option and didn't run across anything.  was there a specific case
> where {vars}->{defines} wasn't initalized properly in the constructor (like
> t/SMOKE or something)?

Yup, t/SMOKE was the one. It needs more polishing, but for now this fix was 
neded to get it running.

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

Mime
View raw message