httpd-test-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: [PATCH] vhost_socket tweak
Date Wed, 18 Feb 2004 14:30:10 GMT
On Wed, Feb 18, 2004 at 09:05:47AM -0500, Geoffrey Young wrote:
> 
> >  sub vhost_socket {
...

> that all looks reasonable.

Thanks for the review Geoff!

...
> that the appropriate status code is returned seems like a valid test
> that we would want to keep around.  maybe keep this but issue another
> request to test your below logic?

I should have explained this... the issue is that in response to an HTTP
request on an SSL port, mod_ssl in 2.0 issues an "HTTP/0.9" response,
i.e. it just spits out the response body without headers.  This makes
TestRequest.pm:lwp_call() barf.

That mod_ssl bug is not really a regression worth worrying about IMO:
browsers handle the error response just fine, so I was trying to just
detect that it sent the right response body.

Now I think about it maybe a better way to fix this would be to let
lwp_call take an argument to allow it to *not* barf on an "HTTP/0.9"
response:

            if ($1 ne "1.0" && $1 ne "1.1") {
                $error = "response had protocol HTTP/$1 (headers not sent?)";
            }

But working out how lwp_call even gets *called* via GET gives me
headaches.  Can anyone help? 

joe




Mime
View raw message