Return-Path: Delivered-To: apmail-httpd-test-dev-archive@www.apache.org Received: (qmail 70645 invoked from network); 8 Jan 2004 18:45:35 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 8 Jan 2004 18:45:35 -0000 Received: (qmail 80567 invoked by uid 500); 8 Jan 2004 18:44:36 -0000 Delivered-To: apmail-httpd-test-dev-archive@httpd.apache.org Received: (qmail 80504 invoked by uid 500); 8 Jan 2004 18:44:36 -0000 Mailing-List: contact test-dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: test-dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list test-dev@httpd.apache.org Received: (qmail 80452 invoked from network); 8 Jan 2004 18:44:35 -0000 Received: from unknown (HELO secure.exclamationlabs.net) (66.77.29.186) by daedalus.apache.org with SMTP; 8 Jan 2004 18:44:35 -0000 Received: from modperlcookbook.org (pcp05675728pcs.walngs01.pa.comcast.net [69.139.161.218]) (authenticated (0 bits)) by secure.exclamationlabs.net (8.11.6/8.11.6) with ESMTP id i08Iieu17670 for ; Thu, 8 Jan 2004 12:44:40 -0600 Message-ID: <3FFDA510.4040600@modperlcookbook.org> Date: Thu, 08 Jan 2004 13:44:32 -0500 From: Geoffrey Young User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20030225 X-Accept-Language: en-us, en MIME-Version: 1.0 To: test-dev@httpd.apache.org Subject: Re: cvs commit: httpd-test/perl-framework/Apache-Test/lib/Apache Test.pm TestConfigC.pm TestSSLCA.pm References: <20040108171537.5260.qmail@minotaur.apache.org> <3FFDA604.8090203@stason.org> In-Reply-To: <3FFDA604.8090203@stason.org> X-Enigmail-Version: 0.71.0.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N >> - my $has_version = $module->VERSION || 0; >> - return 1 if $has_version >= $version; >> + return 1 if eval { $module->VERSION($version) }; > > > Are you sure you haven't dropped something here? why did you remove the > comparison line? becuase it's both wrong and unnecessary: VERSION ( [ REQUIRE ] ) "VERSION" will return the value of the variable $VERSION in the package the object is blessed into. If "REQUIRE" is given then it will do a comparison and die if the package version is not reater than or equal to "REQUIRE". --Geoff